This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add better user-facing error messages #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or telling people they need to register.
… may not be because we're a guest: we can't tell)
| title: "Failed to load event", | ||
| description: msg, | ||
| title: "Failed to load timeline position", | ||
| description: "Vector was trying to load a specific point in this room's timeline but was unable to find it.", |
There was a problem hiding this comment.
I think we probably need to distinguish between 404 and 403 here?
There was a problem hiding this comment.
As far as I can see, the context API never returns 403, although I might have missed somewhere. Would you expect that to be if you don't have permission to view the event in question?
|
ptal |
|
lgtm |
dbkr
added a commit
that referenced
this pull request
Mar 22, 2016
Add better user-facing error messages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#1101