This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add server type selector and style login flow #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The public server search box is left out for now, so this restyles the existing custom server inputs to more closely approximate the design.
|
Since automated testing of authentication is currently a bit limited, I have tested the following auth features:
|
turt2live
suggested changes
Jan 29, 2019
There was a problem hiding this comment.
The auth parts are a bit complicated to follow, which really just highlights that Matrix login is a hard problem. Overall this definitely looks to be going in the right direction though, which is good to see.
The only real change that needs to be made (I think) is that the Modular stuff should be a real class. We can investigate moving the Modular stuff out of the react-sdk at a alter date, but should do that ASAP.
turt2live
approved these changes
Jan 29, 2019
This was referenced Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes get us closer to the redesign login flow. In particular, it adds the server type selector and updates many of the controls.
Future work will resolve the pending question of one or two phases since it impacts .well-known discovery.
Fixes element-hq/element-web#8167 in broad strokes. Any remaining deviations from the login designs will be tracked in separate issues.