This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix firefox scrolling settings tabs differently #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
jryans
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
Thanks, seems fine to me. 😁
This is a bit of tricky case with flexbox where the default min-height for flex items was changed later on in the life of the spec, so some engines differ on the behavior. I think the Firefox perspective is that Firefox follows the updated spec while Chrome does not for some specific edge cases. A related Firefox bug reveals some of the history here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8408
Might also fix Safari. Source: https://moduscreate.com/blog/how-to-fix-overflow-issues-in-css-flex-layouts/
The other
min-heightis also required as far as I can tell. Changing it on the fly makes no difference, however refreshing causes problems.