Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix typo "Scisors" -> "Scissors" #2652

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Conversation

aaronraimist
Copy link
Contributor

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preferably we wouldn't change anything not changed by npm run i18n as we cannot guarantee translations

Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist
Copy link
Contributor Author

Done. Seems like that is just creating more work for translators though. I assume they translated based on the real word, since scisors isn't a word, and google translate at least confirmed that.

@aaronraimist
Copy link
Contributor Author

Also I didn't run prunei18n but there are tons of strings that could be removed. Someone should probably make a separate PR for that.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It is more work for translators, however accuracy is somewhat more important imo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants