-
-
Notifications
You must be signed in to change notification settings - Fork 829
Maintenance: Clean up some stuff around settings #2685
Conversation
This also fixes a technical bug where one could drag a community from the settings to the LLP
@import "./views/settings/tabs/_SettingsTab.scss"; | ||
@import "./views/settings/tabs/_VoiceSettingsTab.scss"; | ||
@import "./views/settings/tabs/room/_GeneralRoomSettingsTab.scss"; | ||
@import "./views/settings/tabs/room/_RolesRoomSettingsTab.scss"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: IMO settings/room/tabs
and settings/user/tabs
would make more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like a good improvement to make if we ever get rid of room_settings
being a thing elsewhere (which I also want to do, but not right now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have opened element-hq/element-web#8934 to track this
Merging because I'm confident the build will pass and I'm losing patience with waiting 2 hours for a build. |
Fixes element-hq/element-web#8864
Removes need for
DragDropContext
over flair settingsFixes a technical bug where one could drag groups from settings over the LLP
Part of element-hq/element-web#8207
Note: It might be easiest to review this commit-by-commit