Settings button in Room Context Menu

[t3chguy]

Fixes element-hq/element-web#8781

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

[turt2live]

code looks good to me, but I want to run the feature by @lampholder before merging.

Looks like it navigates the user to the room when they click the setting icon, which is the only questionable part imo.

[lampholder]

I bounced this past Nad. Broad support for the idea, with just a few tweaks to the UX required before merging:

• put settings in as the bottom item in the modal, with a line separator above it
• don't change the room you're viewing when you click settings
• modify the settings modal title to say 'Room Settings - Room Name' so it's obvious which room's settings you're modifying
  • usual rules apply about what we use for Room Name - whatever we'd put in the room list panel goes in the settings modal title
  • we should not wrap on the settings modal and should truncate with ellipsis

How's that sound?

[t3chguy]

How's that sound?

Like a lot more work given that RoomSettings will have to get entirely detached from RoomView so that you can access it from anywhere, including Community View and other such unrelated views

Turns out that work already happened for the redesign 🤷‍♂️
Most of the work is done :D

[t3chguy]

So the changes have proved to be rather simple

it does feel a bit repetitive to have the Room Name there in the title and also in the input box but I guess that's only on that tab.

[turt2live]

This should probably be _t("Room Settings - %(roomName)s", { roomName: room.name }) because translations