Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add an indicator to show a room is a direct chat in breadcrumbs #2874

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Add an indicator to show a room is a direct chat in breadcrumbs #2874

merged 1 commit into from
Apr 5, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live requested a review from a team April 4, 2019 20:31
@turt2live turt2live changed the title Add an indicator to show a room is a direct chat Add an indicator to show a room is a direct chat in breadcrumbs Apr 4, 2019
bwindels
bwindels approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort of unfortunate we have to rebuild parts of the roomlist infrastructure (also for notifications) but putting that all at a deeper level could be a bit of work, so yeah. Lgtm!

@turt2live
Copy link
Member Author

sort of unfortunate we have to rebuild parts of the roomlist infrastructure

Also RoomTile, but there's no clear way to make everything happy without a bunch of awkward flags.

@turt2live turt2live merged commit 223498a into develop Apr 5, 2019
@turt2live turt2live deleted the travis/breadcrumbs/dms branch April 5, 2019 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwindels bwindels bwindels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @bwindels