Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Manage PL to manage pinned events in Room Settings Roles Tab #2960

Closed
wants to merge 1 commit into from

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 12, 2019

Fixes element-hq/element-web#5396

image

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team May 14, 2019 21:49
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm however there's a more complex problem: it should only show up if it is set or the labs flag is enabled. I'd generally recommend just holding off on this instead and waiting for it to leave labs, doing it then.

@t3chguy
Copy link
Member Author

t3chguy commented May 14, 2019

Ah, I grepped through the code and couldn't find the labs setting for it so presumed it was released already

@turt2live
Copy link
Member

It's under "feature_pinning"

@Half-Shot
Copy link
Contributor

Wow the roles tab looks ugly these days. I guess that needs a design

@jryans
Copy link
Collaborator

jryans commented Mar 4, 2021

Thanks for making this contribution a while back. Since the code base has changed since this was opened, it no longer applies cleanly, and I don't think there's a need to keep it open in this state, as we can always find the code here again if needed. If you are still interested in pursuing this feature, please discuss with us in #element-dev:matrix.org to find a good approach forward.

@jryans jryans closed this Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need powerlevel setting exposed in RoomSettings for pinning messages
4 participants