This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fail more softly on homeserver liveliness errors #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This performs liveliness checks on the auth pages to try and show a friendlier error. Earlier checks in the app startup are expected to not block the app from loading on such failures. See element-hq/element-web#9828
turt2live
added
notready
X-Release-Blocker
This was referenced Jun 5, 2019
|
This and the partner PRs are blocked on a proper design for the error. |
dbkr
reviewed
Jun 6, 2019
dbkr
reviewed
Jun 7, 2019
| @@ -447,6 +467,7 @@ module.exports = React.createClass({ | |||
| onEditServerDetailsClick={onEditServerDetailsClick} | |||
| flows={this.state.flows} | |||
| serverConfig={this.props.serverConfig} | |||
| canSubmit={this.state.serverIsAlive} | |||
There was a problem hiding this comment.
same here for not preventing form submission without an obvious way to re-check (for registration I guess you could toggle server-type but the user wouldn't know to do that).
There was a problem hiding this comment.
Registration has a different phases cycle from the other 3, so I'm not convinced I need to fix the form here. There is no button to click if the server is down, regardless of liveliness checks: it's just a spinner.
dbkr
approved these changes
Jun 7, 2019
dbkr
reviewed
Jun 7, 2019
But still check so we can clear any errors, maybe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#9828
Requires matrix-org/matrix-js-sdk#938
Requires element-hq/element-web#9960
This performs liveliness checks on the auth pages to try and show a friendlier error. Earlier checks in the app startup are expected to not block the app from loading on such failures.