Be somewhat fuzzier when matching emojis to complete on space

[t3chguy]

1. If an emoji is not found in the json but matches the regex, don't remove what the user is typing.
2. Case insensitive comparison to emoticons in json
3. Strip - from emoticon matches, as the json contains 0 emoticons with - but some make sense, :-D -> :D

These may not be the most correct changes, but they seem to make the feature a lot more usable, and a lot more friendly so seem reasonable.

Fixes element-hq/element-web#9910
Fixes element-hq/element-web#9945
Fixes element-hq/element-web#9921

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

[lampholder]

This seems sane to me.
Case-insensitve emojimatching doesn't appear to introduce any clashes:

root@matrix-riot:~/builds/develop/matrix-react-sdk/node_modules/emojibase-data# python -m json.tool en-gb/compact.json | grep emoticon | cut -d'"' -f4 | tr A-Z a-z | sort | uniq -c
      1 %(
      1 8#
      1 8)
      1 8d
      1 :#
      1 :$
      1 :&
      1 :'(
      1 :')
      1 :'d
      1 :'o
      1 :(
      1 :)
      1 :*
      1 :/
      1 :3
      1 :<
      1 :>
      1 :?
      1 :@
      1 :b
      1 :c
      1 :d
      1 :e
      1 :j
      1 :l
      1 :o
      1 :p
      1 :s
      1 :x
      1 :z
      1 :{>
      1 :|
      1 ;)
      1 ;p
      1 </3
      1 <3
      1 >0)
      1 >:(
      1 >:)
      1 >:/
      1 \\m/
      1 d:
      1 dx
      1 o:)
      1 x(
      1 xd
      1 xo
      1 xp

I think it's worth a shot to see how it feels. It might be that substitutions such as d: for 😩 end up feeling just too jarring, but I'd bet mostly nobody notices and it 'just works' more often.

[jryans]

Thanks for working on this! 😁 It looks reasonable to me, so let's give it a try.

[progserega]

Thank you very much!