This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix favicon/title badge count #3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was using a separate function (in MatrixChat) that didn't take into account whether we were supposed to be hiding the badge for rooms so would include notifs that were hidden everywhere else. Also make it a function & put it in RoomNotifs with all its friends. Fixes element-hq/element-web#3060
jryans
approved these changes
Jun 19, 2019
| const highlight = room.getUnreadNotificationCount('highlight') > 0; | ||
| const notificationCount = room.getUnreadNotificationCount(); | ||
|
|
||
| const notifBadges = notificationCount > 0 && _shouldShowNotifBadge(roomNotifState); |
There was a problem hiding this comment.
I guess this will conflict with your other PR, which I think removed the _.
| if (badges) { | ||
| result.count++; | ||
| if (highlight) { | ||
| result.highlight = true; |
There was a problem hiding this comment.
Are you computing highlight for some future consumer? It's not used below...
There was a problem hiding this comment.
Yeah, I figured it just ought to be consistent with the other function below.
This was referenced Jul 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was using a separate function (in MatrixChat) that didn't
take into account whether we were supposed to be hiding the badge
for rooms so would include notifs that were hidden everywhere else.
Also make it a function & put it in RoomNotifs with all its friends.
Fixes element-hq/element-web#3060