This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Basic diff visualisation for plain text edits #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
approved these changes
Jul 19, 2019
| @@ -115,16 +126,36 @@ export default class EditHistoryMessage extends React.PureComponent { | |||
| ); | |||
| } | |||
|
|
|||
| _diffIt(oldBody, newBody) { | |||
There was a problem hiding this comment.
Nit: Maybe just _diff? Unsure why this method would use an It suffix...
There was a problem hiding this comment.
Whoops, forgot to rename after prototype code :)
| function isPlainMessage(event) { | ||
| const content = getReplacedContent(event); | ||
| return content.msgtype === "m.text" && !content.format; | ||
| } | ||
|
|
||
| export default class EditHistoryMessage extends React.PureComponent { | ||
| static propTypes = { |
There was a problem hiding this comment.
Please add missing prop types.
| @@ -66,6 +66,7 @@ | |||
| "classnames": "^2.1.2", | |||
| "commonmark": "^0.28.1", | |||
| "counterpart": "^0.18.0", | |||
| "diff-match-patch": "^1.0.4", | |||
There was a problem hiding this comment.
Is this a big dependency by any chance?
There was a problem hiding this comment.
Okay, I assume that's not too much in the scheme of things...
jryans
approved these changes
Jul 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#9493