This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add support for IS v2 API with authentication #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
suggested changes
Jul 29, 2019
turt2live
approved these changes
Jul 30, 2019
|
@jryans you have merge conflicts now fwiw |
jryans
force-pushed
the
jryans/is-v2-auth
branch
from
33f2cac to
92dbb58
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the IS v2 API in all existing IS usages. A new auth client object checks for an IS token as needed. All IS call sites pass along the token.
This will fall back to v1 APIs if v2 is not supported for the moment, but this will eventually be removed once servers are updated.
Implements part of MSC2140
Fixes element-hq/element-web#10408
Depends on matrix-org/matrix-js-sdk#1002