Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix html diffs repeating text sometimes #3262

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Fix html diffs repeating text sometimes #3262

merged 1 commit into from
Jul 31, 2019

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented Jul 31, 2019 •
edited
Loading

Fixes element-hq/element-web#10406

Seems like a bug in diff-dom, have reported fiduswriter/diffDOM#90 and added workaround.

Example 1:
image

Example 2:
image

@bwindels bwindels requested a review from a team July 31, 2019 10:29
@jryans jryans requested review from jryans and removed request for a team July 31, 2019 10:44
jryans
jryans approved these changes Jul 31, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems like a reasonable workaround! 😁

@bwindels bwindels merged commit 678c9a7 into develop Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

diff picks up wrong previous part in specific circumstance
2 participants
@bwindels @jryans