feat: code cleanup & emoji replacement in composer

[aviraldg]

No description provided.

[matrixbot]

Can one of the admins verify this patch?

[dbkr]

@matrixbot test this please

[dbkr]

Confusingly, trailing commas are now valid ES6 in object literals, array literals and imports, but not function calls...

Edit: actually babel does let you, but you do have to turn it on, and I guess we haven't

Edit 2: OK, I've added the flag to babel for trailing function commas. You may want to merge develop.

[aviraldg]

:| For consistency:
http://babeljs.io/docs/plugins/syntax-trailing-function-commas/

On Fri, Jul 8, 2016 at 7:48 PM David Baker notifications@github.com wrote:

In src/RichText.js
#335 (comment)
:

•            if (entity && entity.get('type') === 'emoji') {
  

•                return;
  

•            }
  

•        }
  

•        const selection = SelectionState.createEmpty(block.getKey())
  

•            .set('anchorOffset', start)
  

•            .set('focusOffset', end);
  

•        const emojiText = plainText.substring(start, end);
  

•        const entityKey = Entity.create('emoji', 'IMMUTABLE', { emojiUnicode: emojiText });
  

•        newContentState = Modifier.replaceText(
  

•            newContentState,
  

•            selection,
  

•            emojiText,
  

•            null,
  

•            entityKey,
  

Confusingly, trailing commas are now valid ES6 in object literals, array
literals and imports, but not function calls...

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/matrix-org/matrix-react-sdk/pull/335/files/b33452216875ba3ffd09747158bd5e1a12512e96#r70079753,
or mute the thread
https://github.com/notifications/unsubscribe/AAOlRLQEKE_mgIb9QfvZaMrjpUK4ZyUFks5qTlqsgaJpZM4JHyQd
.

[dbkr]

Looks fine, although my cursor disappears after inserting an emoji into the composer. It works if I just carry on typing but it's a bit disconcerting.

[aviraldg]

Yeah, unfortunately :( Facebook's own impl uses the same workaround

What do you want me to do here? Strip trailing commas in functions or wait
for spec + babel transform to land?

On Fri, Jul 8, 2016 at 8:10 PM David Baker notifications@github.com wrote:

Looks fine, although my cursor disappears after inserting an emoji into
the composer. It works if I just carry on typing but it's a bit
disconcerting.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#335 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAOlRNJjk0kS7keeYedH0A18MQls8QA_ks5qTmFQgaJpZM4JHyQd
.

[dbkr]

This comment is now stale