This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
CSS classes to colour offline users differently #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can use the same 66% opacity as idle tiles for offline-with-last-active-time to reduce the visual jarring
| @@ -29,6 +29,23 @@ var PRESENCE_CLASS = { | |||
| "unavailable": "mx_EntityTile_unavailable" | |||
| }; | |||
|
|
|||
|
|
|||
| function presence_class_for_member(presence_state, last_active_ago) { | |||
There was a problem hiding this comment.
hm, doesn't this completely contradict our code style?
https://github.com/matrix-org/matrix-react-sdk/blame/develop/code_style.md#L35
|
oops, thanks. ptal. |
| @@ -29,6 +29,23 @@ var PRESENCE_CLASS = { | |||
| "unavailable": "mx_EntityTile_unavailable" | |||
| }; | |||
|
|
|||
|
|
|||
| function presenceClassForMember(presence_state, last_active_ago) { | |||
There was a problem hiding this comment.
variables are still wrong case, but whatever. let's just try to avoid adding to the mess in future.....
|
lgtm enough |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can use the same 66% opacity as idle tiles for offline-with-last-active-time to reduce the visual jarring
As per element-hq/element-web#1740
Requires element-hq/element-web#1798