This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use separate 3PID add and bind flow for supporting HSes #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes to checking for HS support of separate add and bind when guarding the 3PID account section. For older HSes, we in fact always require an IS for add with bind param, so the previous version of this was incorrect. Part of element-hq/element-web#10839
This changes the paths used for binding emails for discovery to use the new separate bind / unbind APIs on supporting servers. Part of element-hq/element-web#10839
This changes the paths used for binding MSISDNs for discovery to use the new separate bind / unbind APIs on supporting servers. Fixes element-hq/element-web#10839
dbkr
approved these changes
Sep 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the paths used for binding 3PIDs for discovery to use the new
separate bind / unbind APIs on supporting servers.
The 3PID API flow diagrams may be helpful in following how all this fits together.
Fixes element-hq/element-web#10839
Depends on matrix-org/matrix-js-sdk#1038