This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix: Unable to verify email address error #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
suggested changes
Oct 7, 2019
| const ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); | ||
| const ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); | ||
| if (err.errcode === 'M_THREEPID_AUTH_FAILED') { | ||
| Modal.createTrackedDialog("E-mail hasn't been verified yet", "", ErrorDialog, { |
There was a problem hiding this comment.
In our strings, we consistently use "email" instead of "e-mail", so please change all these to "email".
as it's confusing to have nothing happen at all when clicking continue straight away.
unsure why this code seems duplicated?
bwindels
force-pushed
the
bwindels/addemailerror
branch
from
9716855 to
1ab19be
Compare
jryans
approved these changes
Oct 8, 2019
| if (err.errcode === 'M_THREEPID_AUTH_FAILED') { | ||
| Modal.createTrackedDialog("Email hasn't been verified yet", "", ErrorDialog, { | ||
| title: _t("Your email address hasn't been verified yet"), | ||
| description: _t("Click the link in the email you received to verify, " + |
There was a problem hiding this comment.
Since there's no subject after the "and", it's better to drop the "," according to the strange rules of English.
Suggested change
| description: _t("Click the link in the email you received to verify, " + | |
| description: _t("Click the link in the email you received to verify " + |
| if (err.errcode === 'M_THREEPID_AUTH_FAILED') { | ||
| Modal.createTrackedDialog("E-mail hasn't been verified yet", "", ErrorDialog, { | ||
| title: _t("Your email address hasn't been verified yet"), | ||
| description: _t("Click the link in the email you received to verify, " + |
There was a problem hiding this comment.
Suggested change
| description: _t("Click the link in the email you received to verify, " + | |
| description: _t("Click the link in the email you received to verify " + |
jryans
approved these changes
Oct 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#11040
Also added a dialog when server says that e-mail hasn't been verified yet.