This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Wmwragg/room tag menu #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in go pull up from develop once previous commits have been merged
… do, but most of the mechanics are there now
…hat the Text avatar aligns vertically correctly
|
Can one of the admins verify this patch? |
|
LGTM. Thanks for fixing the ordering mess! This should close element-hq/element-web#904 and element-hq/element-web#1629 |
|
@ara4n The ordering stuff isn't perfect, as two backend writes are done, one for the initial tag set without meta, and then the tag is set again, but this time with meta. It was the simplest solution I could come up with without rewriting a whole load of code. It also has the benefit that it will fix historic rooms without tag meta data, which are in a manually ordered tag section - at the moment this is only the "Favourite" section. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A companion branch vector-im/vector-web:wmwragg/room-tag-menu also needs to be merged.
Signed-off-by: William Wragg wm.wragg@gmail.com