This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Don't speak the outgoing message if it is in the Sending state. #4075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Zehe <marcozehe@mailbox.org>
Signed-off-by: Marco Zehe <marco@marcozehe.de>
MarcoZehe
force-pushed
the
SuppressSpeechWhenSending
branch
from
bf27546 to
636b023
Compare
|
@t3chguy This is the current state. it reduces the number of speaking the message from 3 without this patch, to 2, with this patch. One is definitely the echo coming back from the server, observable especially in cases where the Matrix home server is under heavy load, and the echo comes back with a delay. However, there is still one more time before that echo where this live region triggers, and it seems to be something outside the usual sending state checks, as you can see in the current version of the patch. I exclude basically every state except null. |
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
|
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
… SuppressSpeechWhenSending
jryans
approved these changes
Jul 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to put aria-live="off" on the event tile if the state is Sending. However, this approach does not yet work for some reason. Submitting as draft for collaboration.