Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove Gemini Scrollbars #4217

Merged
merged 11 commits into from
Mar 18, 2020
Merged

Remove Gemini Scrollbars #4217

merged 11 commits into from
Mar 18, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 13, 2020

Fixes element-hq/element-web#10474

TODO (are proving to be a PITA):

  • TagPanel
  • GroupView

Needs loads of testing on various browsers, tested on Chrome and Firefox on Windows 10.

t3chguy added 9 commits March 13, 2020 23:22
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy added 2 commits March 17, 2020 11:53
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy marked this pull request as ready for review March 17, 2020 13:31
@t3chguy t3chguy requested a review from a team March 17, 2020 17:04
@dbkr dbkr requested review from dbkr and removed request for a team March 18, 2020 11:34
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉Thanks!

@jryans
Copy link
Collaborator

jryans commented Mar 18, 2020

@dbkr Did you test in other browsers?

If more testing is still needed, an ad-hoc build would be nice to have.

@t3chguy
Copy link
Member Author

t3chguy commented Mar 18, 2020

Adhoc build up at: http://riots.im/adhoc/gemini1/

@dbkr
Copy link
Member

dbkr commented Mar 18, 2020

Only bug I found was that the scrollbars appearing on hover causes the width of the room tile to change:

scrollbars

@t3chguy
Copy link
Member Author

t3chguy commented Mar 18, 2020

The above mentioned bug already exists as the Room Lists were already gemini-free

@t3chguy t3chguy merged commit 42ee157 into develop Mar 18, 2020
@t3chguy t3chguy deleted the t3chguy/gemini branch April 27, 2020 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove gemini scrollbars
3 participants