This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make email auth component fail better if server claims email isn't validated #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidated matrix-org/synapse#7512 means that (at least) sometimes after clicking on the email validation link and being redirected to riot, the server will claim the email identity auth stage is still incomplete. This meant that we displayed the email identity UIA component but with an empty email address, because we don't know that in the new session. Work around this by assuming that if the email UIA component is being displayed but we don't have an email address input, the link has been clicked and we're just waiting for the poll. Also don't fire off an initial register request if we're already mid-UI-auth, because that's confusing and unnecessary. Also also remove unused requestingToken state. Fixes element-hq/element-web#13434
foldleft
approved these changes
May 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix-org/synapse#7512 means that (at least)
sometimes after clicking on the email validation link and being redirected
to riot, the server will claim the email identity auth stage is still incomplete.
This meant that we displayed the email identity UIA component but with an empty
email address, because we don't know that in the new session. Work around this by
assuming that if the email UIA component is being displayed but we don't have an
email address input, the link has been clicked and we're just waiting for the poll.
Also don't fire off an initial register request if we're already mid-UI-auth, because
that's confusing and unnecessary.
Also also remove unused requestingToken state.
Fixes element-hq/element-web#13434