Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix key backup restore with SSSS #4612

Merged
merged 1 commit into from
May 21, 2020
Merged

Fix key backup restore with SSSS #4612

merged 1 commit into from
May 21, 2020

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented May 21, 2020

The room / session ID params come after the backupInfo for restoring
from SSSS so the options object was being passed into the wrong param.
Roll on TypeScript.

This meant restoring backups worked fine when the key was cached but
failed when it wasn't.

Regressed in #4507

The room / session ID params come after the backupInfo for restoring
from SSSS so the options object was being passed into the wrong param.
Roll on TypeScript.

This meant restoring backups worked fine when the key was cached but
failed when it wasn't.

Regressed in #4507
@dbkr dbkr requested a review from a team May 21, 2020 11:28
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, thanks for the fix!

@dbkr dbkr merged commit 7533a8f into develop May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants