This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Minor improvements to filtering performance #5054
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#14750
These changes are likely best reviewed commit-by-commit.
Collectively these do not improve the situation too well: on a test account they have reduced times for 2.0 seconds to 1.4 seconds per key. We do have some throttle logic in place in these changes, however in this account's case it does not help as the task overall takes longer than the keypress handling.
There is not much more we can do to improve this situation. We can't lazily load room tiles, can't render them elsewhere to put them into the DOM, and can't do much about how tooltips work. If we could somehow do one of these three, it could increase performance by 1-5x. For now though, this is likely going to have to be fine.