This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix various small regressions in the room list's behaviour #5070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#14782 We need to check if the keys changed, not just the values.
Fixes element-hq/element-web#14799 We were checking to see if the tags were visible at render time, but we needed to ensure that they were(n't) included when checking for diffs. This introduces a new kind of object cloning for semantic reasons. This also fixes the selection indicator being a bit off on custom tags.
Fixes element-hq/element-web#14798 (part 1) When we transition from invite to not-invite we need to ensure we clear the invite notification state.
Fixes element-hq/element-web#14798 (part 2) This is in two parts itself: The `RoomSublist` needs to break its references to the `RoomListStore`, so it now clones the room arrays. The `Algorithm` is the other part, which is slightly more complicated. It turns out that we weren't handling splicing as a change in the `ImportanceAlgorithm`, therefore the `Algorithm` wasn't really feeling like it needed to change anything. Further, the `Algorithm` was using the wrong reference to where it should be dumping rooms (`this.cachedRooms` is a getter which returns a different object depending on conditions), so having fixed that we need to ensure that the filtered and sticky maps are also updated when we remove a room. Because we send the new tag through a Timeline update, we'll end up updating the tag later on and don't need to update the filter and sticky collections.
turt2live
added
the
X-Release-Blocker
jryans
approved these changes
Jul 31, 2020
| @@ -136,6 +136,9 @@ export class ImportanceAlgorithm extends OrderingAlgorithm { | |||
| } else { | |||
| throw new Error(`Unhandled splice: ${cause}`); | |||
| } | |||
|
|
|||
| // changes have been made if we made it here, so say so | |||
| return true; | |||
There was a problem hiding this comment.
Why wasn't that caught as a type error...?
|
Merged now to ensure it's part of the upcoming RC. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#14798
Fixes element-hq/element-web#14799
Fixes element-hq/element-web#14782
This is reviewable commit-by-commit (highly recommended)