This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Do not show conf user join/parts #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate trying to take the logic out of react sdk & put it into vector, although it seems like the split is in the wrong place here: a conference user being 'a user that should be hidden' is logic specific to vector's conferencing implementation, not just which users are "conference users". I think this is probably a continuation of existing logic though so I'd probably say let's just fix this when we have standard conferencing and vector is no longer special. |
|
Yeah good point. Ideally things would be split up a lot better since the very idea of showing which event tiles is specific to the layer on top (Vector), and React SDK should just be supplying sensible defaults. |
kegsay
added a commit
that referenced
this pull request
Dec 16, 2015
Do not show conf user join/parts
dtygel
pushed a commit
to coletivoEITA/matrix-react-sdk
that referenced
this pull request
May 10, 2017
…matrix-react-sdk-strings Update from Weblate.
bwindels
pushed a commit
that referenced
this pull request
Oct 9, 2019
…-4.17.15 Bump lodash from 4.17.11 to 4.17.15
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#510
Depends on element-hq/element-web#527