This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 833
File drop UI fixes and improvements #5505
Merged
turt2live
merged 37 commits into
matrix-org:develop
from
SimonBrandner:improve-file-drop-ui
Mar 5, 2021
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
89bc443
Fix file drop UI
SimonBrandner 41e2ffd
Added background
SimonBrandner da97d18
Added a comment
SimonBrandner dcb30b7
Fix left panel resizer
SimonBrandner e70dee0
Fix flickering
SimonBrandner 044e02b
Remove spaces in empty line
SimonBrandner bebbb3b
Merge branch 'develop' into improve-file-drop-ui
SimonBrandner 365d252
Fix removing event listeners
SimonBrandner 5d7e45e
Added dragCounter
SimonBrandner c1a105f
Merge branch 'develop' into improve-file-drop-ui
SimonBrandner ad85764
Fix timeline expansion
SimonBrandner aa4ec9f
Make $droptarget-bg-color more opaque
SimonBrandner 8551855
Add $droptarget-bg-color to the dark theme
SimonBrandner a3001f7
Remove rounded corners of the drop area
SimonBrandner 26b70b6
Remove label background
SimonBrandner 6a7340e
Use new upload icon
SimonBrandner 1c48804
Remove unnecessary class
SimonBrandner 43e1144
Don't use TintableSVG
SimonBrandner 7277c28
Fix weird crash
SimonBrandner 49ea9a4
Remove sdk import
SimonBrandner 1a7f909
Animate icon size
SimonBrandner f0c2684
Fix formatting
SimonBrandner 172cc01
Add background animation
SimonBrandner 3e0558f
Remove droptarget colors
SimonBrandner 49ea83e
i18n
SimonBrandner e90ae2e
Delint
SimonBrandner 819a0b0
min-width
SimonBrandner 0d6a9fc
Remove weird styling
SimonBrandner 11c5aa0
Remove mx_RoomView_container
SimonBrandner 9a5ba07
Fix auxPanel
SimonBrandner 3bed374
Remove unnecessary code
SimonBrandner 3a643e5
Remove unnecessary changes
SimonBrandner ebedd3c
Remove space
SimonBrandner ff00683
Use ===
SimonBrandner 0a4c0b6
Move fileDropTarget to RoomView
SimonBrandner 4476843
Remove unused _t
SimonBrandner 831cc7e
i18n
SimonBrandner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably not necessary here? But there is
draggingFile: false
, is that intentional?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm slightly worried that counting enters/leaves will cause problems and desync (there's a ton of ways to leave a browser window without triggering a dragleave event, making you always +1)
Can we get away with a simple
isDragging
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is the only solution I've found... I don't think I quite understand what you mean by
isDragging
here. There seems to be aisDragging
method inreact-dnd
but I don't think this can be used here. What am I missing?