This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fixes for call UI #5509
Merged
Fixes for call UI #5509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add bottom margin on PiP view * Remove avatar blurring & pause icon for held calls * Change background of incoming call box to match PiP view * Put drop shadow & border radius on PiP view & incoming call box rather than the CallContainer they're in (so they each have their own drop shadow / rounded corners). * Add margin between incoming call box and PiP view
Use 'Switch' if unholding that call would hold another
and change 'paused' to 'on hold'
jryans
approved these changes
Dec 21, 2020
res/css/views/voip/_CallView.scss
Outdated
| @@ -84,6 +88,7 @@ limitations under the License. | |||
| border-radius: 2000px; | |||
| overflow: hidden; | |||
| position: relative; | |||
| /* Blurred avatar images & pause icon for on-hold removed for now | |||
There was a problem hiding this comment.
Would it make more sense to just remove it? Or you expect it to return soon...? It's always available in version control. Anyway, up to you.
There was a problem hiding this comment.
Yeah true, otherwise it'll just hang around in the css for ages
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated by commit
rather than the CallContainer they're in (so they each have their own
drop shadow / rounded corners).
Avatar no longer blurred
Margin between PiP View & Incoming Call
Secondary avatar removed, 'paused' changed to 'on hold'
'Switch' link in PiP view
'Switch' link in large call view
@nadonomy for approval