Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Run TypeScript tests #5537

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Run TypeScript tests #5537

merged 2 commits into from
Jan 12, 2021

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jan 12, 2021

There aren't any yet, but I'm about to write a test and it's going
to be in TypeScript and I don't want to lump this change in with
a bunch of other stuff.

There aren't any yet, but I'm about to write a test and it's going
to be in TypeScript and I don't want to lump this change in with
a bunch of other stuff.
@dbkr dbkr requested a review from a team January 12, 2021 17:38
src/settings/Settings.ts Outdated Show resolved Hide resolved
@t3chguy
Copy link
Member

t3chguy commented Jan 12, 2021

Funnily enough I was about to do the same thing!!

image

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@dbkr
Copy link
Member Author

dbkr commented Jan 12, 2021

Hah. I'm genuinely ashamed of the amount of time I spent trying to figure out why the test I just wrote was not being run. 😢

@t3chguy
Copy link
Member

t3chguy commented Jan 12, 2021

I had a slightly lighter experience, I clicked my IDE's run just this test suite button and the console said "No tests found" which kinda helped me realise what was happening :P

@dbkr dbkr merged commit 291c7fd into develop Jan 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants