Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix VoIP PIP frame color #5701

Merged
merged 7 commits into from
Apr 27, 2021
Merged

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Mar 1, 2021

Fixes #16570
Screenshot_20210427_152456
Screenshot_20210427_152039

@t3chguy t3chguy requested a review from a team March 1, 2021 11:57
@SimonBrandner SimonBrandner marked this pull request as draft March 1, 2021 12:01
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner marked this pull request as ready for review March 1, 2021 12:45
Copy link

@gaelledel gaelledel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the frame colours to these?
Light Theme: #F4F6FA
Dark Theme: #394049

It can then be merged but its core visual style might change again soon.

@SimonBrandner
Copy link
Contributor Author

@gaelledel, it looks great in the dark theme! But I am not so sure about the light theme. I find it quite hard to differentiate it from the panel

Screenshot_20210423_135509
Screenshot_20210423_135551

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner requested a review from gaelledel April 23, 2021 12:35
@gaelledel
Copy link

@SimonBrandner It doesn't seem that there is a drop shadow on the PIP, is there? if you could add this, it'll help to create levels in the hierarchy and will create a better contrast between components. Regarding the colours, we are currently tidying our themes to a more restricted palette and so it is important to stick with the colours I gave you earlier.
The drop shadow should do the trick.

@SimonBrandner
Copy link
Contributor Author

There is a drop shadow but its alpha was very low. This is how it looks at 45%. Is that alright?

Screenshot_20210423_152958
Screenshot_20210423_153009

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@gaelledel
Copy link

The shadow is too large in width, could you try that?
box-shadow: 0px 4px 20px rgba(0, 0, 0, 0.5);

@SimonBrandner
Copy link
Contributor Author

Here:
Screenshot_20210423_160207

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@turt2live turt2live requested a review from a team April 23, 2021 16:44
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks! 😄

@gaelledel
Copy link

@SimonBrandner Could I get a screenshot of the PIP in Light and dark with the whole UI in the background? That'll allow me to see the drop shadow better and in context

@SimonBrandner
Copy link
Contributor Author

@gaelledel, sure - I've updated the description with fullscreen images

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@jryans
Copy link
Collaborator

jryans commented Apr 27, 2021

@gaelledel has told me this is good to go with the opacity change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants