-
-
Notifications
You must be signed in to change notification settings - Fork 829
Conversation
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
5a2c754
to
9ffef8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change the frame colours to these?
Light Theme: #F4F6FA
Dark Theme: #394049
It can then be merged but its core visual style might change again soon.
@gaelledel, it looks great in the dark theme! But I am not so sure about the light theme. I find it quite hard to differentiate it from the panel |
19b88f3
to
b975906
Compare
b975906
to
d757b7d
Compare
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner It doesn't seem that there is a drop shadow on the PIP, is there? if you could add this, it'll help to create levels in the hierarchy and will create a better contrast between components. Regarding the colours, we are currently tidying our themes to a more restricted palette and so it is important to stick with the colours I gave you earlier. |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
The shadow is too large in width, could you try that? |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me, thanks! 😄
@SimonBrandner Could I get a screenshot of the PIP in Light and dark with the whole UI in the background? That'll allow me to see the drop shadow better and in context |
@gaelledel, sure - I've updated the description with fullscreen images |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@gaelledel has told me this is good to go with the opacity change. |
Fixes #16570