Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Tweak cross-signing copy #5807

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Tweak cross-signing copy #5807

merged 3 commits into from
Mar 26, 2021

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Mar 26, 2021

This makes some Design-approved copy tweaks to the recent cross-signing flow changes.

are-you-sure

accept-on-other-login

verify-this-login

verif-request

unverif-logins

new-login

This makes some Design-approved copy tweaks to the recent cross-signing flow
changes.
@jryans jryans added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Mar 26, 2021
@jryans jryans requested a review from a team March 26, 2021 11:18
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it'd look better if the toast detail was on a new line though, changing colour mid-line but still wrapping looks strange IMO

@jryans
Copy link
Collaborator Author

jryans commented Mar 26, 2021

LGTM, I think it'd look better if the toast detail was on a new line though, changing colour mid-line but still wrapping looks strange IMO

Yeah, I agree and mentioned that as well, but Nad seemed okay with it... I don't think he'll mind if we push it to the next line though, so I'll change it. 😄

@jryans
Copy link
Collaborator Author

jryans commented Mar 26, 2021

Okay, updated to look like this:

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants