This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove reliance on DOM API to generated message preview #5908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves element-hq/element-web#14750
When previews are enabled HTML messages rely on the DOM to extract the text from the event.
We can drop our reliance on the DOM and use
sanitizeHtml
only.The important part is to allow no tags and keep
disallowedTagsMode: 'discard'
This can take up to ~2.5ms per room tile rendered on screen from the benchmark I have seen and we perform a double HTML parsing.
sanitizeHtml
.innerHtml
call