Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Another change from recovery passphrase to Security Phrase #5934

Merged
merged 2 commits into from
May 4, 2021

Conversation

aaronraimist
Copy link
Contributor

Guess I missed this one in #5533

Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist
Copy link
Contributor Author

A very similar but slightly different string is used in another file. If you want to pick one then it could be standardized and only translated once.

"Please enter your Security Phrase a second time to confirm.",

Enter your Security Phrase a second time to confirm it.
vs
Please enter your Security Phrase a second time to confirm.

@t3chguy t3chguy requested a review from a team April 29, 2021 11:56
@jryans
Copy link
Collaborator

jryans commented Apr 30, 2021

Enter your Security Phrase a second time to confirm it.
vs
Please enter your Security Phrase a second time to confirm.

The one in CreateSecretStorageDialog.js is what's shown to new accounts, so feel free to drop the "please" from key backup so they are shared.

Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I guess you might intend to add one more change though?

Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist aaronraimist requested a review from jryans May 1, 2021 00:45
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 😄

@jryans jryans merged commit 28128ca into matrix-org:develop May 4, 2021
@aaronraimist aaronraimist deleted the security-phrase-2 branch May 4, 2021 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants