Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add test coverage collection script #5937

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Add test coverage collection script #5937

merged 2 commits into from
Apr 28, 2021

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Apr 28, 2021

This makes it clear to how collect basic test coverage when desired.

See also matrix-org/matrix-js-sdk#1677

This makes it clear to how collect basic test coverage when desired.
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯 !

I just ran the tests with the --coverage flag, and it looks like the coverage/ folder is not listed in .gitignore. It would probably be sensible to add it there to avoid accidental commits

@jryans
Copy link
Collaborator Author

jryans commented Apr 28, 2021

I just ran the tests with the --coverage flag, and it looks like the coverage/ folder is not listed in .gitignore. It would probably be sensible to add it there to avoid accidental commits

So far, I have not done so, because the reporter config here does not make a directory, but sure, could do.

@jryans jryans merged commit 4554124 into develop Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants