This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use passive option for scroll handlers #6113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
suggested changes
Jun 1, 2021
jryans
reviewed
Jun 1, 2021
Also changed the way the React.RefObject is collected
germain-gg
force-pushed
the
gsouquet/improve-layout-rendering
branch
from
344cfff to
73ca6b2
Compare
jryans
approved these changes
Jun 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hinting the browser that they do not need to wait for the event listener to process before flushing the frame as we are not preventing the scroll
https://web.dev/uses-passive-event-listeners/
Particularly impactful on the
TimelinePanelthat fetches thedata-scroll-tokenon every frameBefore 🐌
# After 🐎