This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fixes for sharing room links #6118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Raimist <aaron@raim.ist>
Signed-off-by: Aaron Raimist <aaron@raim.ist>
|
(marking as draft because linter is unhappy, will investigate tomorrow) |
t3chguy
reviewed
Jun 1, 2021
Signed-off-by: Aaron Raimist <aaron@raim.ist>
Signed-off-by: Aaron Raimist <aaron@raim.ist>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things. The first commit stops via parameters from being added to matrix.to URLs when a room alias is shared. As far as I am know these do nothing, they only are used when sharing a room ID.
The second commit makes the "share this room" link in this dialog
use the room alias if it is available. Currently it only uses the room ID.
Possibly addresses element-hq/element-web#17498 depending on what the author meansFixes element-hq/element-web#17498