This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Migrate end to end tests to GitHub actions #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
force-pushed
the
gsouquet/gh-actions-e2e-tests
branch
from
a577bab to
5c62728
Compare
jryans
reviewed
Jun 8, 2021
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
jryans
suggested changes
Jun 9, 2021
jryans
approved these changes
Jun 10, 2021
| @@ -0,0 +1,27 @@ | |||
| name: Develop jobs | |||
There was a problem hiding this comment.
Yes, this is a bit pedantic, but the "jobs" suffix seems quite redundant... Everything in a workflow will be a job, so there's no need to have that in the name, I think?
Suggested change
| name: Develop jobs | |
| name: Develop |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing to you, GitHub Actions! This pull request migrates end to end tests pipelines to GitHub
What is worth noting about the changes
retention_policyof 14 days has been introduced for the end to end tests logs. I could not think of a good reasons why this would be kept for longerxlargeinstance in GitHub Actions but the runtime takes 5mn on GitHub on average versus 5mn45s on BuildKite