Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Sanitize ChatInviteDialog #626

Merged
merged 7 commits into from
Jan 19, 2017
Merged

Sanitize ChatInviteDialog #626

merged 7 commits into from
Jan 19, 2017

Commits on Jan 18, 2017

  1. Attempt to sanitize ChatInviteDialog a bit

     * Use binds rather than onFoo functions which aren't actually
       handler functions themselves but return them
     * Rename onKeyUp to moveSelectionDown etc,, reserving onKeyUp
       for "a key has been released" rather than, "the up arrow key
       has been pressed"
    dbkr committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    f105ec2 View commit details
    Browse the repository at this point in the history
  2. Make behaviour of ChatInviteDialog more consistent

     * Pressing enter now always adds whatever was in the input box
       to the invite list, if it's a valid address (previously it
       added it to the list of it was a search result but submitted
       the form straight away if there were no results).
     * Remove isValidAddress as it was only used in the context of
       testing whether its return value was true or null (where null
       meant "unsure") so just use getAddressType instead.
    dbkr committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    7b7728c View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2017

  1. Configuration menu
    Copy the full SHA
    d8bcc1f View commit details
    Browse the repository at this point in the history
  2. Keep old behaviour of submitting on enter

    if input is empty
    dbkr committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    2a08aba View commit details
    Browse the repository at this point in the history
  3. Remove duplicate case handled above

    And fix typo where it was handled
    dbkr committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    ee1f6c7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a2ff1cd View commit details
    Browse the repository at this point in the history
  5. Use null instead of false

    dbkr committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    afa384c View commit details
    Browse the repository at this point in the history