This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Convert VoiceUserSettingsTab to TS #6340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
commented
Jul 9, 2021
Comment on lines
+48
to
+50
| export default class VoiceUserSettingsTab extends React.Component<{}, IState> { | ||
| constructor(props: {}) { | ||
| super(props); |
There was a problem hiding this comment.
I have my doubts about this being right
There was a problem hiding this comment.
I agree with you, it doesn't exactly roll off the tongue.
After looking it up I came to the same conclusion as you, that looks correct but doesn't look right 😅
germain-gg
approved these changes
Jul 9, 2021
Comment on lines
+48
to
+50
| export default class VoiceUserSettingsTab extends React.Component<{}, IState> { | ||
| constructor(props: {}) { | ||
| super(props); |
There was a problem hiding this comment.
I agree with you, it doesn't exactly roll off the tongue.
After looking it up I came to the same conclusion as you, that looks correct but doesn't look right 😅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.