This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
GET /teams from RTS instead of config.json #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the RTS contains config for teams, use GET /teams to get that information so that users will see be able to register as a team (but not yet auto-join rooms, be sent to welcome page or be tracked as a referral).
dbkr
reviewed
Jan 30, 2017
|
|
||
| if (this.props.teamServerConfig && | ||
| this.props.teamServerConfig.teamServerURL && | ||
| !this._rtsClient) { |
There was a problem hiding this comment.
Our usual indenting style here would be:
if (
this.props.teamServerConfig &&
[...]
) {
}
|
We could make the component |
|
Probably ought to |
dbkr
reviewed
Jan 30, 2017
| }).finally(() => { | ||
| this.setState({ | ||
| teamServerBusy: false, | ||
| }); |
There was a problem hiding this comment.
You still want a .done() on the end to catch stray exceptions.
| @@ -297,6 +307,8 @@ module.exports = React.createClass({ | |||
| }, | |||
|
|
|||
| _getRegisterContentJsx: function() { | |||
| var Spinner = sdk.getComponent("elements.Spinner"); | |||
dbkr
approved these changes
Jan 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the RTS contains config for teams, use GET /teams to get that information so that users will see be able to register as a team (but not yet auto-join rooms, be sent to welcome page or be tracked as a referral).