This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix spurious HTML tags being passed through literally #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so they don't claim it;s a wrapper around marked when it's now commonmark, and comment why we render markdown to plaintext which is somewhat unintuitive.
Rather than re-parsing the same output in each function
Rather than keeping one in memory, abusing it in different ways each time and then craefully putting it back the way it was (and in one case, failing, because we forgot to put the `out` method back).
* Only render HTML tags in markdown if they're del tags * Consider non-allowed HTML tags as plain text nodes, so a message of just '<shrug>' doesn't need to be sent as HTML * Consequently rewrite isPlaintext to just look at the parse tree rather than making and gutting a renderer to walk the tree (now we're using a library that actually produces a meaningfgul parse tree). * Tweak when we put \n on text output to avoid putting \n on the end of messages. Fixes element-hq/element-web#3065
richvdh
approved these changes
Feb 2, 2017
src/Markdown.js
Outdated
| const isMultiLine = is_multi_line(node); | ||
|
|
||
| if (isMultiLine) this.cr(); | ||
| html_if_tag_allowed.call(this, node); |
There was a problem hiding this comment.
is there a reason not to make html_if_tag_allowed a proper member function rather than having to faff with call?
There was a problem hiding this comment.
Yep, it would need to be on the node, not the Markdown object.
|
Yeah, I was thinking it would also be pretty easy to test. They may have to wait until post-release though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First 3 commits tidy up code (or just comments) with no functional changes.
Last commit fixes element-hq/element-web#3065 and a couple of other bits as described in the commit message.
Fixes element-hq/element-web#3065