-
-
Notifications
You must be signed in to change notification settings - Fork 833
Conversation
Use the /login endpoint of the RTS to get the team token when the user has successfully logged in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a shame that this makes it even easier to discover the team token for a team. In future what we could do is store the team token in user account data.
src/Lifecycle.js
Outdated
@@ -228,6 +228,11 @@ function _restoreFromLocalStorage() { | |||
return false; | |||
} | |||
} | |||
const RtsClient = require("./RtsClient"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be at the top as an import?
@@ -210,6 +210,8 @@ module.exports = React.createClass({ | |||
window.addEventListener('resize', this.handleResize); | |||
this.handleResize(); | |||
|
|||
Lifecycle.initRtsClient(this.props.config.teamServerConfig.teamServerURL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this want to be done conditionally on there being a team server URL, as otherwise it looks like we'll always be creating a client but with an undefined URL.
Yes, if we want to be serious about isolating teams in a secure way then we'd need to support it from account data. |
Use the /login endpoint of the RTS to get the team token when the user has successfully logged in.