Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Debounce read marker update on scroll #6774

Merged
merged 2 commits into from
Sep 9, 2021

Commits on Sep 9, 2021

  1. Debounce read marker update on scroll

    Reverts #6751 in
    favour of debouncing the updates to read markers, because it seems
    allowing the scroll to be 1px away from the bottom was important for
    some browsers and meant they never got to the bottom.
    
    We can fix the problem instead by debouncing the update to read
    markers, because the scroll state gets reset back to the bottom when
    componentDidUpdate() runs which happens after the read marker code
    does a setState(). This should probably be debounced anyway since
    it doesn't need to be run that frequently.
    
    Fixes element-hq/element-web#18961
    Type: bugfix
    dbkr committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    eba815a View commit details
    Browse the repository at this point in the history
  2. Update comment too

    Co-authored-by: Travis Ralston <travisr@matrix.org>
    dbkr and turt2live committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    da06c8a View commit details
    Browse the repository at this point in the history