This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Do not push a dummy element with a scroll token for invisible events #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an event does not `wantTile`, do not add a dummy element with a scroll token, as this can be unperformant with 1000s of events.
|
I think this needs more testing but I'm sure I notice anything unusual. @dbkr, thoughts? |
dbkr
approved these changes
Feb 23, 2017
|
Seems fairly safe to me: at least, I hope our scrolling is not so fragile that removing empty |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an event does not
wantTile, do not add a dummy element with a scroll token, as this can be unperformant with 1000s of events.This undoes part of #162, which made sure that invisible events could still be scrolled to, but ultimately they're invisible so there's no need to be able to scroll to them.