This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Clarify non-e2e vs. e2e /w composers placeholder #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For E2E rooms, display "Send an encrypted message…" otherwise display "Send a plaintext message…" as the placeholder for the input box in [old] message composer.
dbkr
reviewed
Feb 21, 2017
This is true... could use "unencrypted" ? This sounds quite scary though. |
|
perhaps "send message (unencrypted)". agreed that 'plaintext' is jargon. |
dbkr
approved these changes
Feb 22, 2017
dbkr
reviewed
Feb 23, 2017
| @@ -286,12 +286,16 @@ export default class MessageComposer extends React.Component { | |||
| key="controls_formatting" /> | |||
| ); | |||
|
|
|||
| const placeholderText = roomIsEncrypted ? | |||
| "Send a message (unencrypted)…" : "Send a message…"; | |||
There was a problem hiding this comment.
I think I've just spotted a problem with this... ;)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For E2E rooms, display "Send an encrypted message…" otherwise display "Send a plaintext message…" as the placeholder for the input box in [old] message composer.
Fix for element-hq/element-web#2850