Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Task/colors 12 (reorganize theme files again) #7212

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Nov 28, 2021

Type: task


This matches the color order on light and dark themes which makes them easier to compare which is great when you're looking for duplicates and unnecessary variables


Doesn't do any user-facing changes


Please review carefully as this is a big change that could lead to regressions


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://61a4d222e101383c68ea5c9e--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@SimonBrandner SimonBrandner added the X-Blocked The PR cannot move forward in any capacity until an action is made label Nov 28, 2021
@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Nov 28, 2021
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner removed the X-Blocked The PR cannot move forward in any capacity until an action is made label Nov 29, 2021
@SimonBrandner SimonBrandner marked this pull request as ready for review November 29, 2021 13:20
@SimonBrandner SimonBrandner requested a review from a team as a code owner November 29, 2021 13:20
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for doing this valuable work.

@andybalaam andybalaam merged commit f5f1f18 into matrix-org:develop Nov 29, 2021
@SimonBrandner SimonBrandner deleted the task/colors-12 branch November 29, 2021 16:09
Palid pushed a commit that referenced this pull request Nov 30, 2021
…om-alias

* origin/develop: (118 commits)
  Allow filtering room list during treeview navigation (#7219)
  Improve room list message previews (#7224)
  Fix EmojiPicker lazy loaded rendering bug (#7225)
  Prevent default avatar in UserInfo having pointer cursor (#7218)
  Hide scrollbar if content height is smaller than scroll node height (#7220)
  Add option to disable grouping in TimelinePanel (#7221)
  Prevent duplicate avatars in Event List Summaries (#7222)
  Add right panel chat timeline (#7112)
  Task/colors 12 (reorganize theme files again) (#7212)
  Fix size of portrait images with the SIZE_NORMAL setting. (#7188)
  Task/colors 11 (#7211)
  Respect the home page as a context for the Home space (#7216)
  Fix RoomUpgradeWarningBar exploding (#7214)
  Hide server options hint when disable_custom_urls is true (#7215)
  Polish threads misalignments and UI diversion (#7209)
  Improve right panel resize handle usability (#7204)
  Fix multiline paragraph rendering as single line (#7210)
  Fix Manage Restricted Join Rule Dialog for Spaces (#7208)
  Spaces quick settings (#7196)
  re-enable Spaces e2e tests (#7207)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants