Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Warn users about using e2e for the first time #731

Merged
merged 3 commits into from
Mar 2, 2017
Merged

Warn users about using e2e for the first time #731

merged 3 commits into from
Mar 2, 2017

Conversation

lukebarnard1
Copy link
Contributor

@lukebarnard1 lukebarnard1 commented Mar 1, 2017 •
edited
Loading

@lukebarnard1 lukebarnard1 requested a review from dbkr March 1, 2017 15:44
dbkr
dbkr reviewed Mar 1, 2017
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably OK for a temporary warning, but note that this will 1) re-warn people about e2e on any new browsing sessions and 2) fail to warn you if you log in with a new account after someone else has logged out

If that's OK, lgtm

src/components/structures/RoomView.js Outdated
userHasUsedEncryption = localStorage.getItem('mx_user_has_used_encryption');
}
if (!userHasUsedEncryption) {
var QuestionDialog = sdk.getComponent("dialogs.QuestionDialog");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should start changing these to const

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, missed that

@lukebarnard1
Copy link
Contributor Author

lukebarnard1 commented Mar 1, 2017 •
edited
Loading

  1. re-warn people about e2e on any new browsing sessions

Does it not persist across browsing sessions? I know it won't persist across clients/browsers, but it does persist across new windows/tabs.

  1. fail to warn you if you log in with a new account after someone else has logged out

I thought logging out got rid of all items in local storage? The only things preserved are mx_hs_url and mx_is_url.

@lukebarnard1 lukebarnard1 assigned dbkr and unassigned lukebarnard1 Mar 1, 2017
@dbkr
Copy link
Member

dbkr commented Mar 2, 2017

Oh yes, I think we do completely clear localstorage on logout, so yeah, that should be ok, It's mostly just different browsers (which was what I was trying to say with different browsing sessions).

@dbkr dbkr merged commit 0035a91 into develop Mar 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees

@dbkr dbkr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebarnard1 @dbkr