Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Live beacons: track users live beacons #8061

Merged
merged 14 commits into from
Mar 16, 2022
Merged

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Mar 15, 2022

matrix-org/matrix-spec-proposals#3489

Done:

  • Send m.beacon_info.* state events.
  • track m.beacon_info.* events in room state
  • expose and maintain 'user room has live beacons' property in room state
  • add ability to monitor liveness of beacon

In this PR:

  • get users own beacons from room state, monitor liveness
  • maintain 'user has live beacons' property)

In next PRs:

  • get users own beacons from room state, monitor liveness and show live state
  • produce good unique suffixes for beacon info events
  • geolocate and send m.beacon events for live beacons
  • maintain liveness state of beacons (checking for expiry, flipping isLive on event content)

This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr8061--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@kerryarchibald kerryarchibald force-pushed the psf-662/beacon-store branch 2 times, most recently from 7764181 to dbfa095 Compare March 16, 2022 12:29
Kerry Archibald added 13 commits March 16, 2022 16:03
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 16, 2022
Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald marked this pull request as ready for review March 16, 2022 15:12
@kerryarchibald kerryarchibald requested a review from a team as a code owner March 16, 2022 15:12
@kerryarchibald kerryarchibald changed the title WIP: OwnBeaconStore Live beacons: track users live beacons Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #8061 (20c5ed9) into develop (e677901) will increase coverage by 0.08%.
The diff coverage is 98.46%.

@@             Coverage Diff             @@
##           develop    #8061      +/-   ##
===========================================
+ Coverage    27.02%   27.11%   +0.08%     
===========================================
  Files          866      867       +1     
  Lines        52015    52080      +65     
  Branches     13185    13192       +7     
===========================================
+ Hits         14055    14119      +64     
- Misses       37960    37961       +1     
Impacted Files Coverage Δ
src/stores/OwnBeaconStore.ts 98.46% <98.46%> (ø)

@kerryarchibald kerryarchibald mentioned this pull request Mar 16, 2022
10 tasks
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tests look thorough too - thanks!

@kerryarchibald kerryarchibald merged commit bb6ae3f into develop Mar 16, 2022
@kerryarchibald kerryarchibald deleted the psf-662/beacon-store branch March 16, 2022 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants