This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 830
Live beacons: track users live beacons #8061
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerryarchibald
force-pushed
the
psf-662/beacon-store
branch
2 times, most recently
from
March 16, 2022 12:29
7764181
to
dbfa095
Compare
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
kerryarchibald
force-pushed
the
psf-662/beacon-store
branch
from
March 16, 2022 15:07
fc25240
to
b27b2c9
Compare
kerryarchibald
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
Mar 16, 2022
Signed-off-by: Kerry Archibald <kerrya@element.io>
kerryarchibald
changed the title
WIP: OwnBeaconStore
Live beacons: track users live beacons
Mar 16, 2022
Codecov Report
@@ Coverage Diff @@
## develop #8061 +/- ##
===========================================
+ Coverage 27.02% 27.11% +0.08%
===========================================
Files 866 867 +1
Lines 52015 52080 +65
Branches 13185 13192 +7
===========================================
+ Hits 14055 14119 +64
- Misses 37960 37961 +1
|
10 tasks
dbkr
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tests look thorough too - thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix-org/matrix-spec-proposals#3489
Done:
m.beacon_info.*
state events.m.beacon_info.*
events in room stateuserroom has live beacons' property in room stateIn this PR:
In next PRs:
get users own beacons from room state, monitor livenessand show live statem.beacon
events for live beaconsisLive
on event content)This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr8061--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.