This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
(Room)?Avatar: Request 96x96 avatars on high DPI screens #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I'm slightly worried about totally ignoring the width & height which was actually requested. Surely we should just be multiplying the size of the image we request from the server by the pixel density of the display? So for a 30px avatar on a 2x display we'd request a 60px image... which synapse would then serve us 96px for anyway, given the next size up from 60px is 96px in the default list of resolutions. |
ara4n
suggested changes
Apr 22, 2017
Multiply the dimension by the device pixel ratio and then round it to get the width/height of the thumbnail to use in the request.
|
I modified it to use |
|
lgtm - thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.