This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Unit test tsc fixes part 15 #8104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 21, 2022 18:32
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
kerryarchibald
added
the
T-Task
Codecov Report
@@ Coverage Diff @@
## develop #8104 +/- ##
========================================
Coverage 26.71% 26.71%
========================================
Files 872 872
Lines 52206 52206
Branches 13230 13230
========================================
Hits 13946 13946
Misses 38260 38260 |
turt2live
approved these changes
Mar 22, 2022
|
|
||
| jest.mock("../../../../src/settings/SettingsStore"); | ||
|
|
||
| const _DateSeparator = sdk.getComponent("views.messages.DateSeparator"); | ||
| const DateSeparator = TestUtils.wrapInMatrixClientContext(_DateSeparator); | ||
| const DateSeparator = sdk.getComponent("views.messages.DateSeparator"); |
There was a problem hiding this comment.
We should be able to import this (makes de-skinning a lot easier)
There was a problem hiding this comment.
yay! i hate these
|
|
||
| const CHECKED = "mx_MPollBody_option_checked"; | ||
|
|
||
| const _MPollBody = sdk.getComponent("views.messages.MPollBody"); | ||
| const MPollBody = TestUtils.wrapInMatrixClientContext(_MPollBody); | ||
| const MPollBody = sdk.getComponent("views.messages.MPollBody"); |
|
@turt2live unfortunately importing those components breaks the tests, so I'll leave that out of this change. |
|
It'll be because skinning is terrible, so would recommend waiting for that system to just leave (which will swing by and fix it anyhow) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge diff due to giant snapshot in MPollBody - a wrapper was removed from the snapshot, meaning every line has changed indent and confused github.
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.Preview: https://pr8104--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.